nixos/display-managers/auto: remove #78583
Merged
+78
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screenshot of the release note rendered
It describes things someone could do if they really actually needed root autologin without this module. |
ofborg
bot
added
6.topic: nixos
worldofpeace
force-pushed
the
remove-auto-displaymanager
branch
from
2763c7a to
558d16e
Compare
jtojnar
reviewed
Jan 27, 2020
| { services.xserver.enable = true; | ||
| { | ||
| imports = [ | ||
| ./auto.nix |
There was a problem hiding this comment.
This is better than before but I would much rather do something like
imports = [
(import ./common/auto-login.nix { user = "alice"; })
];at each individual modules.
But it would not be idiomatic and I am not sure if it would not affect the performance negatively.
There was a problem hiding this comment.
This whole thing could really turn into a common testing lib which I think we actually might need.
But I don't think I really want to improve this more just yet, I'd like to see this in 20.03.
|
@jtojnar Changes pushed. I believe I got all the |
jtojnar
reviewed
Jan 28, 2020
jtojnar
reviewed
Jan 28, 2020
worldofpeace
force-pushed
the
remove-auto-displaymanager
branch
2 times, most recently
from
e60c2ce to
5834008
Compare
ofborg
bot
added
10.rebuild-darwin: 0
This module allows root autoLogin, so we would break that for users, but they shouldn't be using it anyways. This gives the impression like auto is some special display manager, when it's just lightdm and special pam rules to allow root autoLogin. It was created for NixOS's testing so I believe this is where it belongs.
worldofpeace
force-pushed
the
remove-auto-displaymanager
branch
from
5834008 to
c95612a
Compare
ofborg
bot
added
10.rebuild-linux: 0
anna328p
pushed a commit
to anna328p/nixpkgs
that referenced
this pull request
Feb 2, 2020
…anager nixos/display-managers/auto: remove
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This module allows root autoLogin, so we would break that for users, but they shouldn't be using it anyways. This gives the impression like auto is some special display manager, when it's just lightdm and special pam rules to allow root autoLogin. It was created for NixOS's testing
so I believe this is where it belongs.
cc @hedning @jtojnar as we discussed this #53843
Things done
I need to check the tests in NixOS still work properly that might rely on auto being enabled but don't have the correct imports or something.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)