Merge pull request #78615 from msteen/bitwarden_rs #78615
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
There are currently two open PRs to update bitwarden_rs to version 1.13.0:
Now that version 1.13.1 has been released and both PRs seem to have stagnated a bit, as the maintainer I thought it best update to this latest version and take the feedback from the other PRs into account, to hopefully finally get the version bump pushed.
Besides the version update and the corresponding changes needed to be made to the module, I also changed the way I handled the defaults, because checking for the config before it was converted to its normalized environment variable style, could lead to a problem when e.g.
webVaultEnabled
is checked, while the user set it withWEB_VAULT_ENABLED
.I also changed the backup service type to
oneshot
, because if I start it manually I expect it to have finished the backup once completed, but I don't believe it should matter much outside this. Please correct me if I am wrong.I have only tested it in so far that I have been using it myself.
cc: @filalex77 @dali99 @Ma27 @Mic92 @bbigras
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)