Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #78615 from msteen/bitwarden_rs #78615

Merged
merged 1 commit into from Jan 30, 2020
Merged

Merge pull request #78615 from msteen/bitwarden_rs #78615

merged 1 commit into from Jan 30, 2020

Conversation

msteen
Copy link
Contributor

@msteen msteen commented Jan 27, 2020

Motivation for this change

There are currently two open PRs to update bitwarden_rs to version 1.13.0:

Now that version 1.13.1 has been released and both PRs seem to have stagnated a bit, as the maintainer I thought it best update to this latest version and take the feedback from the other PRs into account, to hopefully finally get the version bump pushed.

Besides the version update and the corresponding changes needed to be made to the module, I also changed the way I handled the defaults, because checking for the config before it was converted to its normalized environment variable style, could lead to a problem when e.g. webVaultEnabled is checked, while the user set it with WEB_VAULT_ENABLED.

I also changed the backup service type to oneshot, because if I start it manually I expect it to have finished the backup once completed, but I don't believe it should matter much outside this. Please correct me if I am wrong.

I have only tested it in so far that I have been using it myself.

cc: @filalex77 @dali99 @Ma27 @Mic92 @bbigras

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! LGTM - expressive enough, while still works OOTB with SQLite.

@Br1ght0ne Br1ght0ne mentioned this pull request Jan 28, 2020
10 tasks
@dali99 dali99 mentioned this pull request Jan 28, 2020
10 tasks
@msteen msteen requested a review from Mic92 January 30, 2020 10:10
@Mic92 Mic92 changed the title bitwarden_rs: 1.9.1 -> 1.13.1 Merge pull request #78615 from msteen/bitwarden_rs Jan 30, 2020
@Mic92 Mic92 merged commit d72905c into NixOS:master Jan 30, 2020
@Mic92
Copy link
Member

Mic92 commented Jan 30, 2020

Tested on my server!

@ajs124
Copy link
Member

ajs124 commented Jan 30, 2020

We might also want to merge the vault update in #77865

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants