Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.nibabel: 3.0.0 -> 3.0.1 #78618

Merged
merged 3 commits into from Feb 6, 2020
Merged

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Jan 27, 2020

pythonPackages.pydicom: 1.3.0 -> 1.4.1

for pydicom: adds python 3.8 support (previously broken)

for nibabel:

  • this unbreaks the package due to erroring tests in 3.0.0
  • remove obsolete (mostly Python2-related) deps
  • add deps to support MINC, DICOM, and SPM formats
  • only build on x64 due to a dtype bug on Arm64

Refresh of #77472.

Depending package nilearn still fails to build for unrelated reasons [edit: fix pushed]. Also seems to be some issue with Nipype tests taking a long time/hanging with Python 3.8, but this was never building before. Will investigate these separately.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- this unbreaks the package due to erroring tests in 3.0.0
- remove obsolete (mostly Python2-related) deps
- add deps to support MINC, DICOM, and SPM formats
- only build on x64 due to a dtype bug on Arm64
- routine update; unbreaks with Python 3.8 (not supported before 1.4.1)
@FRidh FRidh merged commit 134b645 into NixOS:master Feb 6, 2020
@bcdarwin bcdarwin deleted the update-nibabel branch February 6, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants