Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FSM with transition to nonexistent state should not elaborate #315

Closed
awygle opened this issue Jan 28, 2020 · 1 comment
Closed

FSM with transition to nonexistent state should not elaborate #315

awygle opened this issue Jan 28, 2020 · 1 comment

Comments

@awygle
Copy link
Contributor

awygle commented Jan 28, 2020 •
edited

M(ish)CVE: https://gist.github.com/awygle/00cca56b2d58185f3ab7112739588882

Basically, if you have an FSM transition to a state which doesn't have a corresponding with m.State("NAME") statement, I'd expect it to fail to elaborate.

I'm admittedly very new to nmigen so it's possible I am doing something wrong here, but this seems sufficiently intuitive that even if it's not the intended behavior, I'd argue that perhaps it ought to be.
@awygle awygle closed this as completed Jan 28, 2020
@sbourdeauducq
Copy link
Member

@awygle This repository is still maintained until further notice, let's leave this open here until it is fixed.

@sbourdeauducq sbourdeauducq reopened this Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbourdeauducq @awygle