Skip to content

chromium: 79.0.3945.117 -> 79.0.3945.130 #78584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2020
Merged

chromium: 79.0.3945.117 -> 79.0.3945.130 #78584

merged 2 commits into from
Jan 28, 2020
+25 −11

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 26, 2020 •
edited
Loading

https://chromereleases.googleblog.com/2020/01/stable-channel-update-for-desktop_16.html

This update includes 11 security fixes.

CVEs: CVE-2020-6378 CVE-2020-6379 CVE-2020-6380 CVE-2020-0601

State

Trying to build and test chromium on x86_64 until we have a new maintainer (#78450). I can test google-chrome as well but I cannot test this on AArch64 (and I will most likely not have the time to build Chromium on the beta and dev channels as well).

platform attribute status tester
x86_64 chromium ✔️ @primeos
x86_64 nixosTests.chromium ✔️ @primeos
x86_64 google-chrome ✔️ @primeos
aarch64 chromium ✔️ @thefloweringash

Tested: Browser startup + version matches, Random Browsing, Video+Audio (YouTube), and WebGL.

Additional/optional tests:

platform attribute status tester
x86_64 chromiumBeta builds @primeos
x86_64 google-chrome-beta ✔️ @primeos
x86_64 google-chrome-dev ✔️ @primeos
aarch64 chromiumBeta ✔️ @thefloweringash
aarch64 chromiumDev ✔️ @thefloweringash

cc @bendlas @thefloweringash (sorry, forgot this initially :o)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@primeos
chromium: 79.0.3945.117 -> 79.0.3945.130

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vbgl Vincent Laporte
GPG key ID: EBD582ADDDB1F81F
Expired
Verified
Learn about vigilant mode
cccfd10 
https://chromereleases.googleblog.com/2020/01/stable-channel-update-for-desktop_16.html

This update includes 11 security fixes.

CVEs: CVE-2020-6378 CVE-2020-6379 CVE-2020-6380 CVE-2020-0601
@primeos primeos added 1.severity: security Issues which raise a security issue, or PRs that fix one 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 26, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 26, 2020
@primeos primeos marked this pull request as ready for review January 27, 2020 11:55
@primeos primeos mentioned this pull request Jan 27, 2020
Merged
10 tasks
@primeos
Copy link
Member Author

primeos commented Jan 27, 2020 •
edited
Loading

@thefloweringash could you test this on AArch64 if you have time for it?

Edit: Awesome, thanks :)

@primeos primeos removed the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 27, 2020
@thefloweringash
Copy link
Member

platform attribute status tester
aarch64 chromium ✔️ @thefloweringash
aarch64 chromiumBeta ✔️ @thefloweringash
aarch64 chromiumDev ✔️ @thefloweringash

Tested running, version, video+audio playback on YouTube.

@primeos
chromium: Add myself (@primeos) as provisional maintainer
4ad78e6 
I don't really have the hardware resources nor time to do this properly,
but I'll try to keep a watch on Chromium (updates, PRs, and issues)
until we've found a new team [0].
Testing will be performed on a best effort basis (no guarantees :o).

I've also briefly documented the current maintainer
roles/responsibilities and added `meta.longDescription`.

[0]: NixOS#78450
@ofborg ofborg bot requested review from thefloweringash and bendlas January 28, 2020 22:29
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Jan 28, 2020
@primeos primeos merged commit 595f379 into NixOS:master Jan 28, 2020
@primeos primeos mentioned this pull request Jan 28, 2020
Closed
10 tasks
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@primeos @anna328p
Merge pull request NixOS#78584 from primeos/chromium
ee6cf25 
chromium: 79.0.3945.117 -> 79.0.3945.130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefloweringash thefloweringash

@bendlas bendlas

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @thefloweringash