Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libirecovery: 2019-01-28 -> 2020-01-14, idevicerestore: 2019-02-14 -> 2019-12-26 #78577

Merged
merged 3 commits into from Jan 27, 2020
Merged

libirecovery: 2019-01-28 -> 2020-01-14, idevicerestore: 2019-02-14 -> 2019-12-26 #78577

merged 3 commits into from Jan 27, 2020

Conversation

leo60228
Copy link
Member

Motivation for this change

I was curious about restoring an iPhone on Linux and noticed this package was out of date by a few months.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nh2 January 26, 2020 21:57
nh2
nh2 approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me; I also added another commit to update libimobiledevice.

@nh2 nh2 merged commit 58480f5 into NixOS:master Jan 27, 2020
@nh2
Copy link
Contributor

nh2 commented Jan 27, 2020

Thanks!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@nh2 @dtzWill
Merge pull request NixOS#78577 from leo60228/idevicerestore-2019-12-26
598aa86 
libirecovery: 2019-01-28 -> 2020-01-14, idevicerestore: 2019-02-14 -> 2019-12-26
(cherry picked from commit 58480f5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leo60228 @nh2