Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-prosession: add vim plugin #78656

Merged
merged 1 commit into from Jan 29, 2020
Merged

vim-prosession: add vim plugin #78656

merged 1 commit into from Jan 29, 2020

Conversation

GovanifY
Copy link
Member

This adds https://github.com/dhruvasagar/vim-prosession to vimPlugins.

Motivation for this change

Wanted better session management in vim which this plugin provides

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [ N/A ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [ N/A ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • [ N/A ] Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member

timokau commented Jan 29, 2020

This does not quite fit Contributing.md. Please revisit the section about commit message formatting. You could also compare with prior commits that have added vim plugins: https://github.com/NixOS/nixpkgs/commits/master/pkgs/misc/vim-plugins/vim-plugin-names

timokau
timokau requested changes Jan 29, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above. Sorry if it comes over as snarky, it isn't intended that way.

@GovanifY
Copy link
Member Author

GovanifY commented Jan 29, 2020 •
edited

@timokau it does not come as snarky, don't worry! I based myself on this vimPlugins PR #69418 but it seems like I took the only one misformatted^^".
Either way the commit message is now changed.

jonringer
jonringer reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[3 built, 2 copied (32.9 MiB), 6.9 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78656
1 package were built:
vimPlugins.vim-prosession

@jonringer jonringer merged commit 274d02e into NixOS:master Jan 29, 2020
@timokau
Copy link
Member

timokau commented Jan 29, 2020 •
edited

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@timokau timokau timokau requested changes

Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GovanifY @timokau @jonringer @Janik-Haag