Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidenv: add emulator v29.3.6 #78623

Closed
wants to merge 2 commits into from

Conversation

fmnxl
Copy link

@fmnxl fmnxl commented Jan 27, 2020

Motivation for this change

Android SDK packages are getting out of date. The bash script to automatically generate the packages derivation seems to be broken, and I will attempt to fix it in the near future.

Things done
  • Adds an updated version of the android emulator (v29.3.6)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date N/A

  • Fits CONTRIBUTING.md.

@lucafavatella
Copy link
Contributor

This PR seems still current - as I do not see reference to emulator 29 in master.

(I am having a quick look at the androidenv-related PRs - hence this comment.)


I understand this PR is meant to be a short term solution for getting emulator 29 until the script for automatic generation of the related config is fixed and re-run.

The bash script to automatically generate the packages derivation seems to be broken ...

I understand the script in question is generate.sh, whose usage is documented.

I wonder if the project has a way (CI cron weekly job?) for periodically checking for these kinds of semi-automatically generated configurations:

  • Whether the invocation of generate.sh still succeeds.
  • Whether the invocation of generate.sh still generates the same output - so if some body has to call it manually it still works predictably.
  • Whether new version are available (and ideally automatically prepare a PR).

@fmnxl
Copy link
Author

fmnxl commented Mar 9, 2020

@lucafavatella Thanks for your comment. Yes, this was a quick fix to get emulator v29.

Like you said the long term solution should be to get generate.sh t run and run regularly and auto updates the generated files.

I'm not a Nix expert, but I'm not sure why the generated files are part of this package. If it can be built by the user, then we won't need to maintain this package for every version upgrade.. I guess it's something to do with determinism.

@lucafavatella
Copy link
Contributor

@fmnxl Thanks for coming back to me! Your changes saved me a lot of time while trying to get a recent emulator to run. I am trying to propose this in (still draft) PR #82118 so you are welcome to have a look to that so we get your changes (hopefully) merged soon.

@stale
Copy link

stale bot commented Sep 5, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 5, 2020
@numinit
Copy link
Contributor

numinit commented Sep 19, 2020

Possibly superseded by #89775

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 19, 2020
@numinit numinit self-assigned this Dec 12, 2020
@Mic92 Mic92 closed this in #89775 Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants