Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cupy to find the thrust library #78611

Merged
merged 1 commit into from Feb 10, 2020
Merged

Allow cupy to find the thrust library #78611

merged 1 commit into from Feb 10, 2020

Conversation

cstich
Copy link
Contributor

@cstich cstich commented Jan 27, 2020

cupy needs the thrust library for a subset of functionality and this let's cupy find the library. The pull request also fixes a ModuleNotFoundError when importing cupy. This is my very first pull request, so I am happy for any feedback/comments.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

also, please squash commits

@cstich
This allows cupy to find the thrust library which is needed among oth…
e647b8b 
…er things for cupy.argsort

Removed unnecessary dependencies

Remove extra whitespace
@cstich
Copy link
Contributor Author

cstich commented Jan 31, 2020

Just squashed the commits into one

@FRidh FRidh merged commit eaeb87a into NixOS:master Feb 10, 2020
@FRidh
Copy link
Member

FRidh commented Feb 10, 2020

In the future, have commits start with their attribute name, so e.g.:
python3Packages.cupy: find thrust library

@cstich cstich deleted the cupy branch February 11, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cstich @jonringer @FRidh @Janik-Haag