Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Plack: run some more tests #78587

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

perlPackages.Plack: run some more tests #78587

wants to merge 1 commit into from
+4 −0

Conversation

alyssais
Copy link
Member

Motivation for this change

tests r good

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alyssais
Copy link
Member Author

@GrahamcOfBorg build perlPackages.Plack

@aanderse
Copy link
Member

@alyssais are you going to make your way back around to this at some point?

@alyssais
Copy link
Member Author

alyssais commented Mar 2, 2020

@alyssais are you going to make your way back around to this at some point?

I don’t have a Darwin machine to test on, and this change introduces a build failure to Darwin.

stigtsp
stigtsp reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the following makes tests pass on Darwin

  nativeBuildInputs = stdenv.lib.optional stdenv.isDarwin shortenPerlShebang;
  preCheck = stdenv.lib.optionalString stdenv.isDarwin ''
    shortenPerlShebang t/Plack-Middleware/cgi-bin/cgi_dir.cgi
  '';

@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 29, 2020 01:41
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp left review comments

@zakame zakame Awaiting requested review from zakame zakame will be requested when the pull request is marked ready for review zakame is a code owner

@dasJ dasJ Awaiting requested review from dasJ dasJ will be requested when the pull request is marked ready for review dasJ is a code owner

Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alyssais @aanderse @stigtsp @wegank