Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protontricks: 1.3.1 -> 1.4 #78647

Merged
merged 1 commit into from Feb 5, 2020
Merged

protontricks: 1.3.1 -> 1.4 #78647

merged 1 commit into from Feb 5, 2020

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jan 28, 2020

Changes included in the upgrade:

  • Protontricks now uses setuptools_scm. Specify SETUPTOOLS_SCM_PRETEND_VERSION to workaround missing .git.
  • Start running tests that were introduced in 1.3.
  • Override wine used in winetricks from all-packages.nix instead of protontricks/default.nix.
Motivation for this change

Update to latest version and start running tests

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- Specify SETUPTOOLS_SCM_PRETEND_VERSION to workaround missing .git
- Start running tests that were introduced in 1.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants