Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #78601 from foxit64/master #78601

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Merge pull request #78601 from foxit64/master #78601

merged 4 commits into from
Jan 28, 2020
+98 −45

Conversation

foxit64
Copy link
Contributor

@foxit64 foxit64 commented Jan 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Debian and Arch-Linux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Frostman
Copy link
Member

Tested on my system (x86_64) - builds fine and binary works correctly. Diff LGTM as well.

Mic92
Mic92 reviewed Jan 28, 2020
View reviewed changes
pkgs/servers/monitoring/telegraf/default.nix
@@ -27,6 +27,6 @@ buildGoPackage rec {
description = "The plugin-driven server agent for collecting & reporting metrics.";
license = licenses.mit;
homepage = https://www.influxdata.com/time-series-platform/telegraf/;
maintainers = with maintainers; [ mic92 roblabla ];
maintainers = with maintainers; [ mic92 roblabla foxit64 ];
Copy link
Member

@Mic92 Mic92 Jan 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add yourself to maintainers/maintainer-list.nix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! #78709

@Mic92
Copy link
Member

Mic92 commented Jan 28, 2020

@GrahamcOfBorg test telegraf

@foxit64 foxit64 mentioned this pull request Jan 28, 2020
Closed
10 tasks
@Mic92 Mic92 changed the title telegraf 1.12.1 -> 1.13.2 Merge pull request #78601 from foxit64/master Jan 28, 2020
@Mic92 Mic92 merged commit af1d755 into NixOS:master Jan 28, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@Mic92 @anna328p
Merge pull request NixOS#78601 from foxit64/master
d2ef87e 
telegraf 1.12.1 -> 1.13.2
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

Assignees
No one assigned
Labels
12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@foxit64 @Frostman @Mic92 @Janik-Haag