Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paraview: prefix PYTHONPATH #78602

Merged
merged 1 commit into from Jan 28, 2020
Merged

paraview: prefix PYTHONPATH #78602

merged 1 commit into from Jan 28, 2020

Conversation

jobojeha
Copy link
Member

Motivation for this change

wrapping pvbatch with --prefix gives the possibility to add additional python modules to PYTHONPATH
see #78438

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jobojeha
paraview: prefix PYTHONPATH
f4e87eb 
--prefix gives the possibility to add additional python modules to path
@ofborg ofborg bot requested a review from dguibert January 27, 2020 12:52
dguibert
dguibert approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@dguibert dguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
thanks

@dguibert dguibert merged commit 8754b61 into NixOS:master Jan 28, 2020
@dguibert dguibert mentioned this pull request Feb 1, 2020
Closed
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@dguibert @anna328p
Merge pull request NixOS#78602 from jobojeha/feature/paraview-pythonp…
fa3fb13 
…ath-prefix

paraview: prefix PYTHONPATH
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguibert dguibert dguibert approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jobojeha @dguibert @Janik-Haag