Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/bash: configure $LS_COLORS for interactive shells #78660

Merged
merged 1 commit into from
Feb 5, 2020
Merged

nixos/bash: configure $LS_COLORS for interactive shells #78660

merged 1 commit into from
Feb 5, 2020
+13 −0

Conversation

buckley310
Copy link
Contributor

@buckley310 buckley310 commented Jan 28, 2020 •
edited by matthewbauer
Loading

Motivation for this change

This change configures the LS_COLORS environment variable by default for interactive bash shells.
This adds more colors to ls for things like highlighting orphaned symlinks, and colorizing files by type.

Ubuntu 19.10, Debian 9.5, Centos 8, and Fedora 31 have this configured by default.

Closes #74317

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 28, 2020
@Ma27 Ma27 merged commit 87d4951 into NixOS:master Feb 5, 2020
@buckley310 buckley310 deleted the dircolors branch October 8, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ls from coreutils doesn't colorize orphaned symlinks, should this be changed?
2 participants
@buckley310 @Ma27