Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elixir_1_10: init at 1.10.0 #78599

Merged
merged 1 commit into from Jan 28, 2020
Merged

elixir_1_10: init at 1.10.0 #78599

merged 1 commit into from Jan 28, 2020

Conversation

cw789
Copy link
Contributor

@cw789 cw789 commented Jan 27, 2020

Set elixir_1_10 as default elixir version.
Removed elixir_1_5 as support has faded out now.

Motivation for this change

Be fast on new versions!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

Let us be fast!
cc @the-kenny @Havvy @couchemar @ankhers

@Br1ght0ne
Copy link
Member

What's wrong with the evaluation? Is elixir_1_5 still used somewhere?

@cw789
Copy link
Contributor Author

cw789 commented Jan 27, 2020

Is elixir_1_5 still used somewhere?

Ohh, it seems to be used in top-level - all-packages.nix.
I wasn't aware of that.

@cw789
elixir_1_10: init at 1.10.0
e3863ab 
Set elixir_1_10 as default elixir version.
Removed elixir_1_5 as support has faded out now.
@cw789
Copy link
Contributor Author

cw789 commented Jan 27, 2020

@filalex77 Should be fixed now?

@worldofpeace worldofpeace merged commit e22b99b into NixOS:master Jan 28, 2020
@cw789 cw789 deleted the elixir_update branch January 29, 2020 07:26
@cw789
Copy link
Contributor Author

cw789 commented Jan 29, 2020

Thank you guys. 🙏

anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
@worldofpeace @anna328p
Merge pull request NixOS#78599 from cw789/elixir_update
4c99edd 
elixir_1_10: init at 1.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankhers ankhers ankhers approved these changes

@couchemar couchemar couchemar approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
6.topic: erlang 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cw789 @Br1ght0ne @ankhers @couchemar @worldofpeace