New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sendgrid-python: init at 6.1.1 #78649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,34 @@ | |||
# Incoming Parse endpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file? I don't see it being used by the derivation.
|
||
meta = with lib; { | ||
description = "Twilio SendGrid library for Python"; | ||
homepage = https://pypi.org/project/sendgrid/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the pypi location
homepage = https://pypi.org/project/sendgrid/; | |
homepage = "https://github.com/sendgrid/sendgrid-python"; |
pkgs/top-level/python-packages.nix
Outdated
@@ -6225,6 +6227,8 @@ in { | |||
|
|||
send2trash = callPackage ../development/python-modules/send2trash { }; | |||
|
|||
sendgrid = callPackage ../development/python-modules/sendgrid {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sendgrid = callPackage ../development/python-modules/sendgrid {}; | |
sendgrid = callPackage ../development/python-modules/sendgrid { }; |
ditto
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To comply with CONTRIBUTING.md please have the commit message name be of the format
<pkg-name>: <subject-line>
for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes
in your case, the commit messages should be:
maintainers: add <name>
pythonPackages.python-http-client: init at <version>
pythonPackages.sendgrid: init at <version>
If you're unfamiliar editing git history, I would recommend looking into git rebase --interactive
and git add --patch
xfoxawy = { | ||
email = "xfoxawy@gmail.com"; | ||
github = "xfoxawy"; | ||
githubId = 5111856; | ||
name = "Mohammed Kamal"; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this into a separate commit:
maintainers: add <name>
|
||
meta = with lib; { | ||
description = "Twilio SendGrid Quickly and easily access any RESTful or RESTful-like API"; | ||
homepage = https://pypi.org/project/python-http-client/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rfc 45
homepage = https://pypi.org/project/python-http-client/; | |
homepage = "https://pypi.org/project/python-http-client/"; |
checkPhase = '' | ||
test --ignore=tests/test_app.py | ||
''; | ||
|
||
propagatedBuildInputs = [ flask pyyaml six pytest mock codecov coverage python-http-client]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usual order for python packages
checkPhase = '' | |
test --ignore=tests/test_app.py | |
''; | |
propagatedBuildInputs = [ flask pyyaml six pytest mock codecov coverage python-http-client]; | |
propagatedBuildInputs = [ flask pyyaml six pytest mock codecov coverage python-http-client]; | |
checkPhase = '' | |
test --ignore=tests/test_app.py | |
''; |
checkPhase = '' | ||
test --ignore=tests/test_app.py | ||
''; | ||
|
||
propagatedBuildInputs = [ flask pyyaml six pytest mock codecov coverage python-http-client]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is quite a few packages, please do one per line
checkPhase = '' | |
test --ignore=tests/test_app.py | |
''; | |
propagatedBuildInputs = [ flask pyyaml six pytest mock codecov coverage python-http-client]; | |
checkPhase = '' | |
test --ignore=tests/test_app.py | |
''; | |
propagatedBuildInputs = [ | |
flask | |
pyyaml | |
... | |
]; |
I marked this as stale due to inactivity. → More info |
Superseded by #110456 |
Motivation for this change
Sendgrid is famous email service provider, my company depend on the python lib to send emails.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)