Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onesixtyone: init at unstable-2019-12-26 #78609

Merged
merged 1 commit into from Apr 2, 2020
Merged

onesixtyone: init at unstable-2019-12-26 #78609

merged 1 commit into from Apr 2, 2020

Conversation

fishi0x01
Copy link
Member

@fishi0x01 fishi0x01 commented Jan 27, 2020 •
edited

Motivation for this change

Add onesixtyone tool for fast SNMP enumeration

Things done

Build and run successful locally on Ubuntu18.04. Installed via:

nix-env -f $NIXPKGS -iA onesixtyone
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fishi0x01 fishi0x01 changed the title onesixtyone: init at 0.3.3 init: onesixtyone at 0.3.3 Jan 27, 2020
@fishi0x01 fishi0x01 changed the title init: onesixtyone at 0.3.3 onesixtyone: init at 0.3.3 Jan 27, 2020
@eonpatapon
Copy link
Contributor

Build and execution work fine for me

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/119

@fishi0x01 fishi0x01 changed the title onesixtyone: init at 0.3.3 onesixtyone: init at unstable-2019-12-26 Mar 20, 2020
@fishi0x01
Copy link
Member Author

The onesixtyone git repo does not offer releases. I recently learned here that in those cases the version should be unstable-${date of last commit}. That's why I adjusted the version now to unstable-2019-12-26.

@fishi0x01 fishi0x01 requested a review from danieldk March 20, 2020 20:03
@danieldk
Copy link
Contributor

I can't really test the program itself, but it builds fine on Darwin now as well.

@fishi0x01 fishi0x01 requested a review from danieldk March 21, 2020 14:31
@Mic92 Mic92 merged commit 5b806fe into NixOS:master Apr 2, 2020
@fishi0x01 fishi0x01 deleted the fishi0x01/onesixtyone branch April 2, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fishi0x01 @eonpatapon @nixos-discourse @danieldk @Mic92