[css-pseudo] Fix text selection and drag-and-drop for pseudo-elements #21808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 14, 2020
Before this patch, if you had a tree like <div><div::before>abc</div::before>def</div> and you tried to select "bc", Chromium would end up selecting "ef" in some cases. Similarly, trying to drag a text and drop it between "bc", would end up inserting the text between "ef". This patch fixes the problem, now trying to select "bc" won't select anything. And dropping some text between "bc" will insert it between the "cd". BUG=1051685 TEST=external/wpt/css/css-pseudo/text-selection.html TEST=fast/css-generated-content/drag-and-drop.html The 2nd test is internal because I didn't manage to properly simulate drag and drop using testdriver.js Change-Id: Iedd594b46022ed434bdb1462232c717ec08f5304 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047287 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#741909}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2047287
branch
from
e578588
to
3b3dc52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, if you had a tree like
<div><div::before>abc</div::before>def</div>
and you tried to select "bc", Chromium would end up selecting "ef" in
some cases. Similarly, trying to drag a text and drop it between "bc",
would end up inserting the text between "ef".
This patch fixes the problem, now trying to select "bc" won't select
anything. And dropping some text between "bc" will insert it between
the "cd".
BUG=1051685
TEST=external/wpt/css/css-pseudo/text-selection.html
TEST=fast/css-generated-content/drag-and-drop.html
The 2nd test is internal because I didn't manage to properly simulate
drag and drop using testdriver.js
Change-Id: Iedd594b46022ed434bdb1462232c717ec08f5304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047287
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#741909}