Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ogdf: init at 2020.02 #80143

Merged
merged 5 commits into from Feb 19, 2020
Merged

ogdf: init at 2020.02 #80143

merged 5 commits into from Feb 19, 2020

Conversation

wavewave
Copy link
Contributor

@wavewave wavewave commented Feb 14, 2020 •
edited

Motivation for this change

OGDF: Open Graph Drawing Framework C++ library is initially packaged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wavewave
Copy link
Contributor Author

@mmahut I've changed as suggested. Thanks!

@veprbl
Copy link
Member

veprbl commented Feb 18, 2020

@GrahamcOfBorg build ogdf

@veprbl
! fixup style
64a00c0
@veprbl
! fixup restrict to i686/x86_64
7f32c5a 
imports cpuid.h on gnu toolchain, that is only available on those
@veprbl
Copy link
Member

veprbl commented Feb 19, 2020

@GrahamcOfBorg build ogdf

@veprbl veprbl merged commit bc6c7f6 into NixOS:master Feb 19, 2020
@veprbl
Copy link
Member

veprbl commented Feb 19, 2020

@wavewave Thank you!

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 19, 2020
@wavewave @dtzWill
ogdf: init at 2020.02 (NixOS#80143)
7b68702 
Restricted to i686/x86_64 as it imports cpuid.h on gnu toolchain

Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
(cherry picked from commit bc6c7f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wavewave @veprbl @mmahut