-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sort_db is broken #1236
Comments
Any idea what the input to |
Doesn't matter? |
I'll also point out that sorting ordered constructions (tuples and list) can break the data? |
In Python 3, you can't sort something which has a None object in it...
|
And? What's you point? Your code is attempting to modified already ordered data? That's not a valid thing to do? |
To be clear: |
The issue is that JSON only has arrays and dicts. In our JSON data structure, almost all our lists (that are not 2 in length) should be sets (and |
Almost every list in the JSON is ordered. For example, the timing data is defined as the following tuple: https://github.com/SymbiFlow/prjxray/blob/master/prjxray/timing.py#L162
|
That just isn't true? |
Some examples;
|
And I already provided a counter example? You cannot just start reordering ordered data and expect it to work? Your code was broken. |
We have two options;
The ordered data is currently, lists of wire pairs/coordinates and the timing data? Are there others? |
Or just don't guess and randomly break things? |
Inside the JSON
We can thus;
I believe you wish to do (1) -- correct? |
Neither: Define [] as always ordered. Fuzzers that write [] should have a stable order. |
This is an example of ordered data, not unordered data. |
The pairs inside |
True |
The text was updated successfully, but these errors were encountered: