Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: c8d53312a59b
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5443eee47c0f
Choose a head ref
  • 9 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 23, 2019

  1. nixos/postgresql: support 0750 for data directory 

    This is rework of part of #46670.
My usecase was to be able to inspect PG datadir as wheel user.

PG11 now allows starting server with 0750 mask for data dir.
`groupAccess = true` now does this automatically. The only thing you have to do
is to set group ownership.

For PG10 and below, I've described a hack how this can be done. Before this PR
hack was impossible. The hack isn't ideal, because there is short
period of time when dir mode is 0700, so I didn't want to make it official.

Test/example is present too.
    @danbst
    danbst committed Jul 23, 2019
    Copy the full SHA
    92a015d View commit details
    Browse the repository at this point in the history

  2. postgresql: allow changing initidb arguments via module system 

    Closes #18829

+ some cleanups
    @danbst
    danbst committed Jul 23, 2019
    Copy the full SHA
    7e4e37f View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. addressed review comments and some fixes

    @danbst
    danbst committed Jul 24, 2019
    Copy the full SHA
    b643e0a View commit details
    Browse the repository at this point in the history

  2. whoops

    @danbst
    danbst committed Jul 24, 2019
    Copy the full SHA
    e54ad98 View commit details
    Browse the repository at this point in the history

  3. change groupAccess to tristate, to not force chmod on dataDir. 

    Making mask either 0700 or 0750 is too restrictive..
    @danbst
    danbst committed Jul 24, 2019
    Copy the full SHA
    363ba3f View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2019

  1. WIP

    @danbst
    danbst committed Aug 13, 2019
    Copy the full SHA
    d9ff157 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Merge branch 'master' into postgresql_group

    @danbst
    danbst committed Feb 14, 2020
    Copy the full SHA
    2c77c53 View commit details
    Browse the repository at this point in the history

  2. let's not support group mode for versions pre-11. 

    The only fix is to change mode to 0700 before start, because otherwise postgresql
doesn't start, and error is non-obvious.
    @danbst
    danbst committed Feb 14, 2020
    Copy the full SHA
    84535e0 View commit details
    Browse the repository at this point in the history

  3. nixos/postgresql: support 0750 for data directory (#65245) 

    * nixos/postgresql: support 0750 for data directory

This is rework of part of #46670.
My usecase was to be able to inspect PG datadir as wheel user.

PG11 now allows starting server with 0750 mask for data dir.
`groupAccess = true` now does this automatically. The only thing you have to do
is to set group ownership.

For PG10 and below, I've described a hack how this can be done. Before this PR
hack was impossible. The hack isn't ideal, because there is short
period of time when dir mode is 0700, so I didn't want to make it official.

Test/example is present too.

* postgresql: allow changing initidb arguments via module system

Closes #18829

+ some cleanups

* addressed review comments and some fixes

* whoops

* change groupAccess to tristate, to not force `chmod` on dataDir.

Making mask either 0700 or 0750 is too restrictive..

* WIP

* let's not support group mode for versions pre-11.

The only fix is to change mode to 0700 before start, because otherwise postgresql
doesn't start, and error is non-obvious.
    @danbst
    danbst committed Feb 14, 2020
    Copy the full SHA
    5443eee View commit details
    Browse the repository at this point in the history