Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix-prefetch-git: report deepClone & leaveDotGit #80091

Merged
merged 2 commits into from Feb 19, 2020
Merged

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 14, 2020

Motivation for this change

Just like in be30ba8 we want fetchgit (builtins.fromJSON (builtins.readFile ./src.json)) to work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Just like in be30ba8
we want `fetchgit (builtins.fromJSON (builtins.readFile ./src.json))` to work.
`git repack` and `git gc` sometimes print “Nothing new to pack.”
to stdout, which breaks redirecting output to JSON file.

Let’s move the stdout of all git calls where it is not used to stderr
so that we still receive the info but it does not pollute our output.
@jtojnar jtojnar merged commit 477ea06 into master Feb 19, 2020
@jtojnar jtojnar deleted the npregit-dumpall branch February 19, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant