Make external/wpt/css/cssom-view/elementFromPoint.html robust on browsers #21796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 14, 2020
…sers This patch changes "elementFromPoint.html" to call |getBoundingClientRect()| on <img> instead of <area> because all browsers returns different value for <area>, maybe size-less inline element, for improving robustness of test. Because test itself verifies |elementFromPoint()| instead of |getBoundingClientRect()|, this patch doesn't change testing Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#741374}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2054472
branch
from
914e30c
to
6a96fb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes "elementFromPoint.html" to call |getBoundingClientRect()|
on <img> instead of <area> because all browsers returns different value for
<area>, maybe size-less inline element, for improving robustness of test.
Because test itself verifies |elementFromPoint()| instead of
|getBoundingClientRect()|, this patch doesn't change testing
Change-Id: I40fc2c6c9cef696dc5c9f3428913b2d73ffaf5f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054472
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741374}