Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed QT problem #80144

Merged
merged 2 commits into from Feb 15, 2020
Merged

fixed QT problem #80144

merged 2 commits into from Feb 15, 2020

Conversation

btlvr
Copy link
Contributor

@btlvr btlvr commented Feb 14, 2020

Motivation for this change

inspectrum wasn't working. It would throw the following error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
Things done

I tried to follow the instructions outlined in #65399
This is my first time commiting to nixpkgs, so please let me know if I did anything wrong.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mogorman February 14, 2020 23:18
@veprbl
Copy link
Member

veprbl commented Feb 14, 2020

@GrahamcOfBorg build inspectrum

@veprbl
Copy link
Member

veprbl commented Feb 15, 2020

@GrahamcOfBorg build inspectrum

@veprbl veprbl merged commit 0bfb755 into NixOS:master Feb 15, 2020
@veprbl
Copy link
Member

veprbl commented Feb 15, 2020

@btlvr Thank you for your contribution. Next time, please familiarize yourself with the contributing guidelines [1]. Namely, the commit messages need to conform to our standard.

[1] https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@btlvr btlvr deleted the fix-inspectrum branch February 15, 2020 04:39
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 15, 2020
@btlvr @dtzWill
inspectrum: add qt wrapper, cleanup (NixOS#80144)
7a8e1cd 
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
(cherry picked from commit 0bfb755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@veprbl veprbl veprbl approved these changes

@mogorman mogorman Awaiting requested review from mogorman

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@btlvr @veprbl @worldofpeace @Janik-Haag