Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.imagecorruptions: init at 1.1.0 #80095

Merged
merged 1 commit into from Feb 15, 2020
Merged

pythonPackages.imagecorruptions: init at 1.1.0 #80095

merged 1 commit into from Feb 15, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Feb 14, 2020 •
edited

Motivation for this change

pythonPackages.imagecorruptions: init at 1.1.0

This is needed by imgaug tests
#80098
#79982

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai @jonringer

@Rakesh4G Rakesh4G mentioned this pull request Feb 14, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.imagecorruptions
@GrahamcOfBorg build python3Packages.imagecorruptions
@GrahamcOfBorg build python38Packages.imagecorruptions

@jonringer
Copy link
Contributor

failures dont look related to the package

@jonringer jonringer merged commit 3064c90 into NixOS:master Feb 15, 2020
@Rakesh4G Rakesh4G deleted the imagecorruptions branch February 15, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Rakesh4G @jonringer