Fix xrInputSource_gamepad_disconnect flakiness #21812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 15, 2020
When run in parallel, the test can sometimes fail complaining that "device.mojom.Gamepad" is not a constructor; however, this does not seem to repro when run indepdently. Changing this to use a map with the appropriate default properties set seems to fix this issue when run in parallel. Fixed: 1052539 Change-Id: I24877e8bad709abda69e13b94455a174a100c6b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058005 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741678}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2058005
branch
from
55c705f
to
054ed9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run in parallel, the test can sometimes fail complaining that
"device.mojom.Gamepad" is not a constructor; however, this does not
seem to repro when run indepdently.
Changing this to use a map with the appropriate default properties
set seems to fix this issue when run in parallel.
Fixed: 1052539
Change-Id: I24877e8bad709abda69e13b94455a174a100c6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058005
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741678}