Update test processing of StageParameters changes #21811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 15, 2020
Currently the test code only sends the stage parameters as Display Info updates. Now that WebVr has been removed, this code path is one that is being considered for removal. The real runtimes utilize both this VRDisplayInfo update path as well as updating the stage parameters with frame data. This changes the test runtime to do the same (i.e. send up stage parameters via both DisplayInfo and FrameData). Fixed: 983363 Change-Id: I3c0a3f59b97163c3ac3b8f4b6529183142688d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056501 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#741671}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2056501
branch
from
d67a410
to
07869a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test code only sends the stage parameters as Display Info
updates. Now that WebVr has been removed, this code path is one that is
being considered for removal.
The real runtimes utilize both this VRDisplayInfo update path as well as
updating the stage parameters with frame data.
This changes the test runtime to do the same (i.e. send up stage
parameters via both DisplayInfo and FrameData).
Fixed: 983363
Change-Id: I3c0a3f59b97163c3ac3b8f4b6529183142688d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056501
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741671}