Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.imgaug: 0.4.0 - Fixed disabled/broken augmenters tests #80098

Merged
merged 1 commit into from Feb 15, 2020
Merged

pythonPackages.imgaug: 0.4.0 - Fixed disabled/broken augmenters tests #80098

merged 1 commit into from Feb 15, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Feb 14, 2020 •
edited

Motivation for this change

pythonPackages.imgaug: 0.4.0 - Fixed disabled/broken augmenters tests
fixes disabled tests from : #79982
Tests pass post changes.
imgaug_tests.txt

Depends upon: #80095

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai @jonringer

@Rakesh4G Rakesh4G mentioned this pull request Feb 14, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

do you mind rebasing?

@Rakesh4G
Copy link
Contributor Author

do you mind rebasing?

Sure. I am doing it.

@Rakesh4G Rakesh4G marked this pull request as ready for review February 15, 2020 05:54
@ofborg ofborg bot requested a review from CMCDragonkai February 15, 2020 06:05
@FRidh
Copy link
Member

FRidh commented Feb 15, 2020

@GrahamcOfBorg build python3Packages.imgaug

jonringer
jonringer approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonringer jonringer merged commit e94a84a into NixOS:master Feb 15, 2020
@worldofpeace
Copy link
Contributor

Hey, just a heads up here the commit message didn't match the contribution guidelines, but the pr title did. e94a84a

pythonPackages.imgaug: fix broken augmenters tests

@jonringer
Copy link
Contributor

ah, my bad didn't really check since the PR was titled correctly

@Rakesh4G
Copy link
Contributor Author

Hey, just a heads up here the commit message didn't match the contribution guidelines

@worldofpeace @jonringer , Sorry. I will keep this in mind. Thanks again.

@Rakesh4G Rakesh4G deleted the imgaug-0.4.0-tests-fix branch February 17, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rakesh4G @jonringer @FRidh @worldofpeace