Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.run-in-machine: Port to Python #80099

Merged
merged 2 commits into from Feb 18, 2020
Merged

nixosTests.run-in-machine: Port to Python #80099

merged 2 commits into from Feb 18, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Feb 14, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Contributor Author

tfc commented Feb 14, 2020 •
edited

@GrahamcOfBorg test run-in-machine

@tfc tfc mentioned this pull request Feb 14, 2020
Closed
@veprbl veprbl added the 6.topic: testing Tooling for automated testing of packages and modules label Feb 14, 2020
@tfc tfc changed the title Port run in machine test nixosTests.run-in-machine: Port to Python Feb 14, 2020
@worldofpeace
Copy link
Contributor

@tfc Oh no, forgot to merge #79659.

@worldofpeace
Copy link
Contributor

Can you have the PR have only 8dffaca and 39174b8?

@tfc
Copy link
Contributor Author

tfc commented Feb 14, 2020

Can you have the PR have only 8dffaca and 39174b8?

@worldofpeace done

@worldofpeace worldofpeace merged commit c4de30c into NixOS:master Feb 18, 2020
@worldofpeace
Copy link
Contributor

Thanks @tfc ❤️

@tfc tfc deleted the port-run-in-machine-test branch February 25, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: testing Tooling for automated testing of packages and modules 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tfc @worldofpeace @veprbl