So Spyder wants a later version of python-language-server (PLS). PLS now wants numpy, pandas, matplotlib, and pyqt5 for testing. Is there any concern with adding huge attributes to checkInputs, like there would be for closure size if they were added to buildInputs?

Builds but needs more checking.

Still to do (notes to myself):

• double check setup.pys etc. to make sure I haven't missed any dependencies or put test deps in buildInputs
• test each changed attribute with all python versions
• update meta.broken, some of these have discontinued python 2
• grep for other packages that use these and test them too
• cq-editor (which uses spyder) complains from spyder.widgets.sourcecode.codeeditor import CodeEditor\ ModuleNotFoundError: No module named 'spyder.widgets.sourcecode'

I've tried enabling the tests on Jedi, 786 failed, 1904 passed. I'm not sure what's wrong with it, I've tried adding in numpydoc, sphinx and coverage like tox.ini indicates but that makes no difference. I read a few of those 786 failure logs and can't see any useful information in there.

On the plus side, master's version of jedi produces similar numbers of fails and passes, so I guess I haven't made anything worse?

Todo:

• Add qdarkstyle <2.7 for electron-cash and electrum

Almost there, but I'm getting test failures with python27Packages.python-language-server, specifically test_flake8_no_checked_file and test_flake8_lint both fail during a subprocess call with OSError: [Errno 2] No such file or directory.

pyls version 29.1 was the previous nixpkgs version and it still builds successfully. In 29.2 pyls started using subprocess. palantir/python-language-server@5850ac0#diff-12a2d0e8313818662c49cc658cd8e8ae

I don't think I know enough to fix this one. @Mic92 (the maintainer), do you have any suggestions?

Was flake8 in the $PATH during check phase?

Thanks @Mic92, I had previously put flake8 into checkInputs and then accidentally reverted it. Fixed now, and pyls builds for 2.7, 3.6, 3.7 and 3.8.

But Spyder in nixpkgs has been reverted to 3.3, so I no longer need to bump pyls' version.

Since I've got it done, should I submit a new PR for python-language-server: 29.1 -> 31.8? Or should we leave nixpkgs at 29.1 until someone actually needs a later version?

Since you put some effort in finding out how to upgrade pyls it might be beneficial if that information does not get lost.