Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport DesktopNames parameter to 20.03 #80200

Merged
merged 1 commit into from Feb 15, 2020
Merged

Backport DesktopNames parameter to 20.03 #80200

merged 1 commit into from Feb 15, 2020

Conversation

ilya-fedin
Copy link
Contributor

Motivation for this change

Backport of #79830 for fixing MATE in 20.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ilya-fedin
nixos/display-managers: Add DesktopNames parameter to generated deskt…
75f90af 
…op session files

Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter.
If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop).

Fixes NixOS#71427

(cherry picked from commit f7768c9)
@worldofpeace worldofpeace added this to the 20.03 milestone Feb 15, 2020
@worldofpeace worldofpeace merged commit f438954 into NixOS:release-20.03 Feb 15, 2020
@worldofpeace worldofpeace mentioned this pull request Feb 15, 2020
Closed
10 tasks
@ilya-fedin ilya-fedin deleted the backport-fix-xdg-current-desktop branch March 15, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ilya-fedin @worldofpeace