Add Xerox Phaser P3250 cups driver #80202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CUPS driver for Xerox Phaser P3250 printer.
flokli
reviewed
Feb 15, 2020
veprbl
reviewed
Apr 20, 2020
| @@ -1067,8 +1067,8 @@ | |||
| githubId = 37037; | |||
| name = "Filip Brcic"; | |||
| keys = [{ | |||
| longkeyid = "rsa2048/0x0123456789ABCDEF"; | |||
| fingerprint = "AAAA BBBB CCCC DDDD EEEE FFFF 0000 1111 2222 3333"; | |||
| longkeyid = "rsa4096/0x96577BD3C105EDA4"; | |||
There was a problem hiding this comment.
Please squash this commit with the first one and make sure that it is signed with this key. Note that adding keys to the maintainer record is optional.
veprbl
reviewed
Apr 20, 2020
| GLOBIGNORE=*.so | ||
| for exe in $out/lib/cups/**/*; do | ||
| echo "Patching $exe" | ||
| patchelf \ |
There was a problem hiding this comment.
We usually suggest people to try autoPatchelfHook instead of manual calls to patchelf.
veprbl
reviewed
Apr 20, 2020
|
|
||
| meta = with stdenv.lib; { | ||
| description = "Xerox's Linux printing driver for Phaser P3250; includes binaries without source code"; | ||
| homepage = http://www.xerox.com/; |
There was a problem hiding this comment.
Suggested change
| homepage = http://www.xerox.com/; | |
| homepage = "https://www.support.xerox.com/support/phaser-3250/file-download/enus.html?contentId=102275"; |
veprbl
reviewed
Apr 20, 2020
| description = "Xerox's Linux printing driver for Phaser P3250; includes binaries without source code"; | ||
| homepage = http://www.xerox.com/; | ||
| license = licenses.unfree; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
Suggested change
| platforms = platforms.linux; | |
| platforms = [ "i686-linux" "x86_64-linux" ]; |
veprbl
reviewed
Apr 20, 2020
| brcha = { | ||
| email = "brcha@yandex.com"; | ||
| github = "brcha"; | ||
| githubId = 37037; |
There was a problem hiding this comment.
Suggested change
| githubId = 37037; | |
| githubId = 37038; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
@brcha Can you address the review comments? |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closed due to no response from OP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CUPS driver for Xeros Phaser P3250 printer.
Motivation for this change
I have a Xerox Phaser P3250dn printer and, while it can work to an extent using a generic postscript driver, advanced options (such as duplex printing) are available only with the proprietary Xerox's driver. Their driver is based on Samsung's driver, but the available samsung-unified-linux-driver doesn't support my particular printer. So I've wrapped their driver into a nix package. I've installed it on my system and the printer works as it should.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)