Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mullvad-vpn: 2020.1 -> 2020.2 #80159

Merged
merged 1 commit into from Feb 17, 2020
Merged

mullvad-vpn: 2020.1 -> 2020.2 #80159

merged 1 commit into from Feb 17, 2020

Conversation

emacsomancer
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Br1ght0ne
Copy link
Member

@GrahamcOfBorg build mullvad-vpn

Br1ght0ne
Br1ght0ne approved these changes Feb 16, 2020
View reviewed changes
Copy link
Member

@Br1ght0ne Br1ght0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@Br1ght0ne Br1ght0ne mentioned this pull request Feb 16, 2020
Closed
@JohnAZoidberg
Copy link
Member

Tested execution of all binary files (usually in ./result/bin/)

Could you please give a bit more details about how you tested it?

@emacsomancer
Copy link
Contributor Author

Tested execution of all binary files (usually in ./result/bin/)

Could you please give a bit more details about how you tested it?

There's a daemon that runs in the background (mullvad-daemon) and a GUI (mullvad-gui) that connects to the daemon. I'm using both of them in a normal fashion.

@emacsomancer emacsomancer mentioned this pull request Feb 16, 2020
Closed
@Br1ght0ne Br1ght0ne mentioned this pull request Feb 17, 2020
Closed
10 tasks
@Br1ght0ne
Copy link
Member

Br1ght0ne commented Feb 17, 2020 •
edited

@emacsomancer Consider renaming this PR to

mullvad-vpn: 2019.10 -> 2020.2

before merging, and closing #79797. Thanks!

@Mic92 Mic92 merged commit 338e1dc into NixOS:master Feb 17, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 17, 2020

Should we backport this one?

@KamilaBorowska
Copy link
Member

@Mic92

The latest version of the Mullvad app resolves DNS leak vulnerabilities affecting users who have “Local network sharing” enabled on either Windows, macOS, or Linux. We strongly recommend all users to upgrade.

Yeah, that sounds like a vulnerability to me. I don't see why not.

@Mic92
Copy link
Member

Mic92 commented Feb 17, 2020

3ffada4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emacsomancer @Br1ght0ne @JohnAZoidberg @Mic92 @KamilaBorowska