Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of units #89

Closed
azonenberg opened this issue Feb 15, 2020 · 1 comment
Closed

Better handling of units #89

azonenberg opened this issue Feb 15, 2020 · 1 comment

Comments

@azonenberg
Copy link
Collaborator

Right now it's kinda assumed that everything is in volts and the few things that aren't are special cased.

This leads to bizarre results like a peak-to-peak measurement on a PLL deviation trace being reported as 1063 V instead of 1063 ps.

We should really have a unified system for specifying X/Y axis units on traces and printing them sanely.
azonenberg added a commit that referenced this issue Feb 16, 2020
@azonenberg
Initial implementation of Unit class (see #89). Not fully integrated …
7af2190 
…everywhere yet.
@azonenberg
Copy link
Collaborator Author

Unit class is now implemented and integrated with pretty much all waveform stuff. Not integrated with measurements yet but those are about to get totally redone anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@azonenberg