Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nushell: fix build by using newer cargo fetcher #80197

Merged
merged 1 commit into from Feb 15, 2020
Merged

nushell: fix build by using newer cargo fetcher #80197

merged 1 commit into from Feb 15, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Feb 15, 2020

Resolves #80117 by using the newer fetcher; see #79975 for details.

Would also be fixed by #80153 eventually, but we want to upgrade Rust packages
either way, so might as well start with the broken ones!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
nushell: fix build by using newer cargo fetcher
cabb10d 
Resolves NixOS#80117 by using the newer fetcher; see NixOS#79975 for details.

Would also be fixed by NixOS#80153 eventually, but we want to upgrade Rust packages
either way, so might as well start with the broken ones!
@bhipple
Copy link
Contributor Author

bhipple commented Feb 15, 2020

@GrahamcOfBorg build nushell

@ofborg ofborg bot requested review from marsam and Br1ght0ne February 15, 2020 20:11
@bhipple bhipple mentioned this pull request Feb 15, 2020
Closed
jonringer
jonringer approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
shell starts fine

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80197
1 package built:
nushell

@jonringer jonringer merged commit a5df5df into NixOS:master Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@marsam marsam Awaiting requested review from marsam

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nushell: fails to build on linux x86_64
2 participants
@bhipple @jonringer