Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dwarf-fortress: 0.44.12 -> 0.47.02 #80072

Merged
merged 4 commits into from Feb 14, 2020
Merged

dwarf-fortress: 0.44.12 -> 0.47.02 #80072

merged 4 commits into from Feb 14, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 13, 2020 •
edited

Motivation for this change

The rest of the ecosystem is slowly catching up.

This adds:

  • 0.47.02 compatible dwarf-therapist
  • 0.47.02 compatible df-hack, even if pre-release
  • latest twbt

Then sets the default df package to be the latest.

There might be some instability with the df-hack prelease and an outdated twbt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

@shazow

shazow
shazow approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@shazow shazow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed nix-env -f . -i dwarf-fortress-full builds as expected on NixOS, dfhack launches with the correct versions.

@shazow
Copy link
Contributor

shazow commented Feb 14, 2020 •
edited

Bonus: Might be worth re-running the cd themes && ./update.sh if you get a chance, just to keep things fresh. :)

@jonringer
Copy link
Contributor Author

did another update, doesn't seem to be any new releases

@shazow
Copy link
Contributor

shazow commented Feb 14, 2020

Awesome, thanks!

@jonringer jonringer merged commit d2b745d into NixOS:master Feb 14, 2020
@jonringer jonringer deleted the dwarf-fortress branch February 14, 2020 20:50
@ghost
Copy link

ghost commented Mar 12, 2020 •
edited by ghost

There've been 2 new minor releases, I tried updating them manually but the process is a bit convoluted for me. Any plans on updating the packages?

@shazow
Copy link
Contributor

shazow commented Mar 12, 2020 •
edited

It's not as hard as it looks. :) If you want to open a PR and ping us for help, I'm happy to help.

#79630 is maybe a better reference. Also https://nixos.wiki/wiki/Nixpkgs/Update_a_package

Otherwise I'm sure one of us will get to it next time we play it. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazow shazow shazow approved these changes

@bendlas bendlas Awaiting requested review from bendlas

@the-kenny the-kenny Awaiting requested review from the-kenny

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @shazow