nixos/btrfs: make autoScrub not prevent shutdown or suspend #80141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I backported this onto the release-19.09 branch, there it works fine both with shutdown and suspend. It would be nice if the scrubbing was resumed/ started again after resuming from suspension. But if this was not trivial to achieve, I'd be in favour of merging this without resumption support. Maybe we can still sneak this into 20.03, @worldofpeace? It'd be a shame if this small bugfix only reached stable in September. |
|
bump @symphorien: Do you see a straight-forward way for resumption or do you prefer to merge this as-is for the time being? |
|
|
|
Merged and backported to 20.03 as 99a3d7a, seeing the absence of opposition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #79086 #79017
can you test this @schmittlauch ?
Things done
Tested on my system, only that scrub is cancelled by suspend.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)