Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glibc: use python3Minimal instead of python3 #80112

Merged
merged 2 commits into from Feb 15, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 14, 2020

Motivation for this change

Improve the speed of bootstrapping process.

I'm sorry I haven't noticed this attribute sooner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64 and aarch64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Confirmed zero impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This should improve the speed of bootstrapping process.
Cost of evaluation also decreases a bit,
but I don't expect that will be significant.
Thanks to python3Minimal.  This reverts part of c203848 NixOS#79738.
@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 14, 2020

Yes thank you, I'm certain of this being backported 👍

Staging automation moved this from WIP to Ready Feb 14, 2020
@Ma27 Ma27 requested a review from lblasc February 14, 2020 20:46
@worldofpeace worldofpeace merged commit 1083046 into NixOS:staging Feb 15, 2020
Staging automation moved this from Ready to Done Feb 15, 2020
@worldofpeace
Copy link
Contributor

backported in ced2b5a 306d76f

@vcunat vcunat deleted the p/glibc-python branch February 15, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants