[Gecko Bug 1615405] eval(nonString)` should not have observable side effects. #21800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After this change we can restrict contentSecurityPolicyAllows callbacks to just strings, because everything else is excluded before calling that callback. Differential Revision: https://phabricator.services.mozilla.com/D62794 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1615405 gecko-commit: bc387540075dc88bb2c0bf165931857ca7e40dfe gecko-integration-branch: autoland gecko-reviewers: tcampbell, baku
wpt-pr-bot
approved these changes
Feb 14, 2020
|
This was a mistake, please do not land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change we can restrict contentSecurityPolicyAllows callbacks to just strings, because everything
else is excluded before calling that callback.
Differential Revision: https://phabricator.services.mozilla.com/D62794
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1615405
gecko-commit: bc387540075dc88bb2c0bf165931857ca7e40dfe
gecko-integration-branch: autoland
gecko-reviewers: tcampbell, baku