Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixosTests.systemd-confinement: Port to Python #80103

Merged
merged 1 commit into from Apr 22, 2020

Conversation

tfc
Copy link
Contributor

@tfc tfc commented Feb 14, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Contributor Author

tfc commented Feb 14, 2020

@GrahamcOfBorg test systemd-confinement

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice 👍

@tfc tfc force-pushed the port-systemd-confinement-test branch from c702391 to 1320f23 Compare February 27, 2020 15:59
@tfc
Copy link
Contributor Author

tfc commented Feb 27, 2020

@GrahamcOfBorg test systemd-confinement

@flokli flokli merged commit 32516e4 into NixOS:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants