tree-sitter: 0.15.7 -> 0.16.4 #80163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes some bugfixes/cleanups to the scripts and packaging, a run of the updater, a bump of the version, an upgrade to the newer cargo fetcher in NixOS#79975, and gets the web assembly portion to compile successfully. Fixes NixOS#75863
|
@GrahamcOfBorg build tree-sitter |
bhipple
commented
Feb 15, 2020
| @@ -22,7 +22,7 @@ let | |||
| res=$(${curl}/bin/curl \ | |||
| --silent \ | |||
| "https://api.github.com/repos/${urlEscape owner}/$(${urlEscapeSh} "$repo")/releases/latest") | |||
| if [[ "$(printf "%s" "$res" | ${jq}bin/jq '.message')" =~ "rate limit" ]]; then | |||
| if [[ "$(printf "%s" "$res" | ${jq}/bin/jq '.message')" =~ "rate limit" ]]; then | |||
There was a problem hiding this comment.
This never worked previously, but its failure just prints a warning :)
| preBuild = '' | ||
| HOME=/tmp | ||
| bash ./script/build-wasm --debug | ||
| ''; |
There was a problem hiding this comment.
We now support web assembly and can remove our old patch (which didn't apply cleanly) and vendoring hacks. Someone who wants to go really above and beyond could also get the JS minify step working, but I'm satisfied taking it to this point.
There was a problem hiding this comment.
Let’s add an option to make the web-ui optional.
Ma27
approved these changes
Feb 15, 2020
|
Thanks! Do you want to add yourself as a maintainer? |
|
Backported the update slightly altered as 57fafc0 to fix the build on release-20.03 as well. |
Ma27
added
the
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes some bugfixes/cleanups to the scripts and packaging, a run of the
updater, a bump of the version, an upgrade to the newer cargo fetcher in #79975,
and gets the web assembly portion to compile successfully.
Fixes #75863
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)