Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use errno attribute to handle socket.error for PY2 and PY3 compatibility #21802

Merged
merged 1 commit into from Feb 14, 2020
Merged

Use errno attribute to handle socket.error for PY2 and PY3 compatibility #21802

merged 1 commit into from Feb 14, 2020

Conversation

ziransun
Copy link
Member

Python 3 has introduced Built-in Exception class 'ConnectionRefusedError'
as a subclass of ConnectionError for connection-related issue.

@ziransun
Use errno attribute to handle socket.error for PY2 and PY3 compatibility
9d0e9f0 
Python 3 has introduced Built-in Exception class 'ConnectionRefusedError'
as a subclass of ConnectionError for connection-related issue.
@wpt-pr-bot wpt-pr-bot added infra wptrunner The automated test runner, commonly called through ./wpt run labels Feb 14, 2020
@jgraham jgraham merged commit f268227 into web-platform-tests:master Feb 14, 2020
@ziransun ziransun deleted the errno branch May 11, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgraham jgraham jgraham approved these changes

@Hexcles Hexcles Awaiting requested review from Hexcles

@KyleJu KyleJu Awaiting requested review from KyleJu

@LukeZielinski LukeZielinski Awaiting requested review from LukeZielinski

@stephenmcgruer stephenmcgruer Awaiting requested review from stephenmcgruer

Assignees

@stephenmcgruer stephenmcgruer

Labels
infra wptrunner The automated test runner, commonly called through ./wpt run
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ziransun @jgraham @stephenmcgruer @wpt-pr-bot