Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 018fac1dc779
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 466c1df3e280
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 12, 2020

  1. knot: put runtime paths outside the nix store 

    Otherwise knot tries to write to non-writable directories.
This for example breaks dnssec signing.
While it's possible to overwrite these path in the configuration,
having a sane defaults is nicer.
    @Mic92
    Mic92 committed Feb 12, 2020
    Copy the full SHA
    6adc09e View commit details
    Browse the repository at this point in the history

  2. knot: drop dynamic user 

    This makes it hard to include secret files.
Also using tools like keymgr becomes harder.
    @Mic92
    Mic92 committed Feb 12, 2020
    Copy the full SHA
    88029bc View commit details
    Browse the repository at this point in the history

  3. knot: add keyFiles option 

    This useful to include tsig keys using nixops without adding those
world-readable to the nix store.
    @Mic92
    Mic92 committed Feb 12, 2020
    Copy the full SHA
    e2ef8b4 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Merge pull request #79266 from Mic92/knot 

    nixos/knot: add keyFiles option
    @Mic92
    Mic92 committed Feb 15, 2020
    Copy the full SHA
    466c1df View commit details
    Browse the repository at this point in the history