Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fastparquet: 0.3.2 -> 0.3.3 #80123

Merged
merged 1 commit into from Feb 14, 2020
Merged

python3Packages.fastparquet: 0.3.2 -> 0.3.3 #80123

merged 1 commit into from Feb 14, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 14, 2020 •
edited

Motivation for this change

fixes build with new pandas

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[2 built (2 failed), 0.0 MiB DL]
error: build of '/nix/store/9pjd33yzyck27hgpzvparwj0l4kjdgv4-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80123
2 package failed to build:
python37Packages.datashader python38Packages.datashader

2 package built:
python37Packages.fastparquet python38Packages.fastparquet

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.fastparquet

@jonringer
Copy link
Contributor Author

fixes a broken build,

datashader will have to be fixed later

@jonringer jonringer merged commit e24c04f into NixOS:master Feb 14, 2020
@jonringer jonringer deleted the fix-fastparquet branch February 14, 2020 17:12
@worldofpeace
Copy link
Contributor

needs backport to 20.03, see #80379 (comment) @jonringer

@jonringer jonringer mentioned this pull request Feb 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace