nanod | nixos/nanod: init at 20.0 #80161
Conversation
This commit adds the node software that is used to participate in the Nano cryptocurrency network.
This change extends the nanod package with a NixOS module to run the daemon as a systemd service.
There was a problem hiding this comment.
Thanks for your contribution to nixpkgs! I'm glad you want to join the maintainer team. I've left some comments which I hope are helpful.
I hope I can convince @mmahut to take a quick look at this too. I'm pretty sure crypto stuff is his cup of tea, and I'm out of my element here.
|
|
||
| enable = mkEnableOption "nanod"; | ||
|
|
||
| dataDir = mkOption { |
There was a problem hiding this comment.
Does this option provide value? I'm entirely ignorant of this software, so it's a genuine question.
| }; | ||
|
|
||
| config = mkIf cfg.enable { | ||
| users.users.nanod = { |
There was a problem hiding this comment.
If dataDir isn't needed can we use DynamicUser instead please?
| users.users.nanod = { | ||
| name = "nanod"; | ||
| group = "nanod"; | ||
| uid = config.ids.uids.nanod; |
There was a problem hiding this comment.
Please take a look through https://github.com/NixOS/rfcs/blob/master/rfcs/0052-dynamic-ids.md
More points if we can go the DynamicUser route, though.
|
|
||
| preStart = '' | ||
| cp ${nodeConfig} ${cfg.dataDir}/config-node.toml | ||
| cp ${rpcConfig} ${cfg.dataDir}/config-rpc.toml |
There was a problem hiding this comment.
No command line option to pass these files in?
| ++ stdenv.lib.optionals (!stdenv.isDarwin) [ ocl-icd opencl-headers ] | ||
| ++ stdenv.lib.optionals stdenv.isDarwin [ Foundation OpenCL ]; | ||
|
|
||
| buildPhase = '' |
There was a problem hiding this comment.
Maybe you should use installTargets = "nano_node"; instead.
| }; | ||
| }; | ||
|
|
||
| rpcConfig = mkOption { |
There was a problem hiding this comment.
Might be more clear to name as: rpcConfig -> rpcConfigFile and rpcConfigOptions -> rpcConfig... but just my opinion, take it or leave it 🤷♂️
| include_directories (${CMAKE_SOURCE_DIR}) | ||
|
|
||
| -set(Boost_USE_STATIC_LIBS ON) | ||
| +add_definitions(-DBOOST_LOG_DYN_LINK) |
There was a problem hiding this comment.
My cmake-fu is a bit rusty, but can't we achieve these results from various cmake flags in nix? 🤔
| ]; | ||
|
|
||
| cmakeFlags = let | ||
| options = { |
There was a problem hiding this comment.
This abstraction seems a bit overkill, especially for two simple values.
|
Hello, I'm a bot and I thank you in the name of the community for your contributions. Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human. If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do: If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list. If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past. If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments. Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel. |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to inactivity from author. |
Motivation for this change
This change introduces
nanod, which is the daemon that is used to participate on the nano cryptocurrency network. Much of the derivation is based off thenano-walletpackage that already exists innixpkgs.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)