Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colorz: init at 1.0.3 #80188

Merged
merged 2 commits into from Feb 23, 2020
Merged

colorz: init at 1.0.3 #80188

merged 2 commits into from Feb 23, 2020

Conversation

skykanin
Copy link
Contributor

Motivation for this change

This PR introduces colorz a python based tool for generation color schemes from images

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 16, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should just be 2 commits:

maintainers: add skykanin
colorz: init at 1.0.3

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/misc/colorz/default.nix Outdated

meta = with lib; {
description = "Color scheme generator";
homepage = https://github.com/metakirby5/colorz;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/metakirby5/colorz;
homepage = "https://github.com/metakirby5/colorz";

Copy link
Contributor Author

@skykanin skykanin Feb 16, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, ok. I didn't use strings for the homepage url since this isn't done in examples from the nixpkgs manual either https://nixos.org/nixpkgs/manual/#chap-meta

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, we need to change that, an rfc was merged recent

@skykanin skykanin force-pushed the master branch 2 times, most recently from 818b52a to 4332dd5 Compare February 17, 2020 02:49
@jonringer
Copy link
Contributor

should just be 2 commits:

maintainers: add skykanin
colorz: init at 1.0.3

https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

jonringer
jonringer approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
application shows usage

https://github.com/NixOS/nixpkgs/pull/80188
1 package built:
colorz

@jonringer jonringer merged commit deb4c21 into NixOS:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skykanin @jonringer