Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1601585] Add a WPT to test selection in a contenteditable element with changing `designMode #21817

Merged
merged 1 commit into from Feb 17, 2020

Conversation

moz-wptsync-bot
Copy link
Collaborator

We should port editor/libeditor/tests/test_bug622371.html to WPT. It was
written for compatibility issue with CKEditor 9 years ago and Gecko and
Blink behave as exactly same. Only Safari normalize the selection into the
end of the text node, but Safari also does not change selection at turning
on/off designMode too. Therefore, all browser engines have implicit
agreement at least that selection shouldn't be changed at changing
designMode.

Differential Revision: https://phabricator.services.mozilla.com/D62813

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1601585
gecko-commit: 331fac3d22bc95beb33d8c46ef72e758847eab7f
gecko-integration-branch: autoland
gecko-reviewers: smaug

…ing `designMode

We should port `editor/libeditor/tests/test_bug622371.html` to WPT.  It was
written for compatibility issue with CKEditor 9 years ago and Gecko and
Blink behave as exactly same.  Only Safari normalize the selection into the
end of the text node, but Safari also does not change selection at turning
on/off `designMode` too.  Therefore, all browser engines have implicit
agreement at least that selection shouldn't be changed at changing
`designMode`.

Differential Revision: https://phabricator.services.mozilla.com/D62813

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1601585
gecko-commit: 331fac3d22bc95beb33d8c46ef72e758847eab7f
gecko-integration-branch: autoland
gecko-reviewers: smaug
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Firefox project.

@jgraham jgraham closed this Feb 17, 2020
@jgraham jgraham reopened this Feb 17, 2020
@moz-wptsync-bot moz-wptsync-bot merged commit 9521d69 into master Feb 17, 2020
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1601585 branch February 17, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants