Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tmux: rename extraTmuxConf to extraConfig #80088

Closed
wants to merge 1 commit into from
Closed

nixos/tmux: rename extraTmuxConf to extraConfig #80088

wants to merge 1 commit into from

Conversation

rissson
Copy link
Member

@rissson rissson commented Feb 14, 2020 •
edited

(cherry picked from commit 9bc7a13)

Motivation for this change

Backporting of #77423

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @fpletz @THammers @kalbasit

@samueldr
Copy link
Member

samueldr commented Feb 14, 2020 •
edited

Hi!

Thanks for contributing to Nixpkgs.

Sorry to be the bearer of bad news. We don't usually backport such changes once the release has gone stable. We've certainly not backported such changes late in the stable period of a release.

What's backported, generally, are non-breaking (often caled 'minor') software updates, and security sensitive updates.

I'm closing this, if you, anyone pinged, or the maintainers of 19.09 (@lheckemann @disassembler) feel this should not have been closed, please reopen.

@samueldr samueldr closed this Feb 14, 2020
@rissson rissson deleted the release-19.09 branch March 4, 2020 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rissson @samueldr