Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea 1.10.3 -> 1.11.0 #80175

Closed
wants to merge 1 commit into from
Closed

gitea 1.10.3 -> 1.11.0 #80175

wants to merge 1 commit into from

Conversation

kolaente
Copy link
Member

Motivation for this change

Gitea major update: https://blog.gitea.io/2020/02/gitea-1.11.0-is-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from disassembler and ehmry February 15, 2020 13:15
@sondr3
Copy link
Contributor

sondr3 commented Feb 15, 2020

Are we touched by this issue?

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 15, 2020

@GrahamcOfBorg test gitea

@aanderse
Copy link
Member

At a quick glance this might be useful for us.

@dR3b
Copy link

dR3b commented Mar 12, 2020

Status?

@kolaente
Copy link
Member Author

Are we touched by this issue?

We probably are, unfortunately I wasn't able to test that because starting the result binary failed with

2020/03/14 16:52:08 routers/init.go:71:GlobalInit() [F] Git module init failed: Failed to execute 'git config --global core.quotepath false': error: could not lock config file $HOME/.config/git/config: Read-only file system

where the error in itself makes sense as my git config is managed through home-manager, but I guess I'm doing it wrong? I was just trying to run ./result-bin/bin/gitea

@Ma27
Copy link
Member

Ma27 commented Mar 20, 2020

Well, it tries to get gitea running as your local user and needs the git config for it.

I just updated gitea locally to 1.11.3 (based on your patch) and while the test and the db migration appear to work fine, the frontend is broken and needs to be built from source by us or we find a tarball with a prebuilt frontend.

Currently investigating which solution is the best :)

@Ma27 Ma27 self-assigned this Mar 20, 2020
@Ma27 Ma27 added this to the 20.03 milestone Mar 20, 2020
@ajs124
Copy link
Member

ajs124 commented Mar 20, 2020

The tarballs listed as gitea-src-$version.tar.gz, e.g. https://github.com/go-gitea/gitea/releases/download/v1.11.3/gitea-src-1.11.3.tar.gz seem to include the prebuilt frontend.

@Ma27
Copy link
Member

Ma27 commented Mar 20, 2020

Indeed, just deployed such a package and it appears to work fine. Will publish the change soon, still doing some more tests :)

@Ma27 Ma27 closed this in cbceee8 Mar 20, 2020
Ma27 added a commit that referenced this pull request Mar 20, 2020
@Ma27
gitea: 1.10.3 -> 1.11.3
1ec2cf2 
Updates `gitea` to the latest version available[1]. Also ensured that
upgrading from `gitea-1.9` (used on NixOS 19.09) to `1.11.3` works
seamlessly.

The derivation required a few more changes this time since `gitea` uses
`npm` now to build the frontend[2]. When using the default tarball from
GitHub, we'd have to build the frontend manually. By fetching a custom
tarball published on every release, we get a prebuilt frontend
(as it was the case on previous versions) and build the backend only from
source.

Co-authored-by: kolaente <k@knt.li>
Closes #80175

[1] https://github.com/go-gitea/gitea/releases/tag/v1.11.3
[2] go-gitea/gitea#10253

(cherry picked from commit cbceee8)
@kolaente kolaente deleted the update-gitea-1.11 branch March 23, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler Awaiting requested review from disassembler

@ehmry ehmry Awaiting requested review from ehmry

Assignees

@Ma27 Ma27

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kolaente @sondr3 @rnhmjoj @aanderse @dR3b @Ma27 @ajs124