Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint.whitelist after 8636d91 #21819

Merged
merged 1 commit into from Feb 16, 2020
Merged

Fix lint.whitelist after 8636d91 #21819

merged 1 commit into from Feb 16, 2020

Conversation

stephenmcgruer
Copy link
Contributor

@stephenmcgruer stephenmcgruer commented Feb 15, 2020

The lint for audit.js is based on the exact line location, which changed when #21804 added two more lines to the file.

The lint for audit.js is based on the exact line location, which changed
when #21804 added two more
lines to the file.
@stephenmcgruer
Copy link
Contributor Author

This is on me; I had failed to notice the lint failing in #21804, as I thought the failures were the stability checks timing out. Sorry!

@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-21819 February 15, 2020 13:27 Pending
@stephenmcgruer
Copy link
Contributor Author

I'm seeing PRs being opened and failing only due to this lint check, and I think we need to unblock that, so I'm going to land this. To use Chromium terminology, 'TBR' @jgraham

@stephenmcgruer stephenmcgruer merged commit 089627b into master Feb 16, 2020
@stephenmcgruer stephenmcgruer deleted the smcgruer/fix-lint branch February 16, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants